Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D75723272 |
This pull request was exported from Phabricator. Differential Revision: D75723272 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D75723272 |
aporialiao added a commit to aporialiao/torchrec that referenced this pull request Jun 13, 2025
Summary: Pull Request resolved: pytorch#3092 Adding the planner input context has to the sharding plan name that's uploaded to manifold. We will use this hash in the next diff to validate that the sharding plan loaded from manifold was generated with the same inputs as the model that it's being loaded for. Reviewed By: micrain Differential Revision: D75723272
abde93b to d1ce27f Compare This pull request was exported from Phabricator. Differential Revision: D75723272 |
aporialiao added a commit to aporialiao/torchrec that referenced this pull request Jun 13, 2025
Summary: Pull Request resolved: pytorch#3092 Adding the planner input context has to the sharding plan name that's uploaded to manifold. We will use this hash in the next diff to validate that the sharding plan loaded from manifold was generated with the same inputs as the model that it's being loaded for. Reviewed By: micrain Differential Revision: D75723272
This pull request was exported from Phabricator. Differential Revision: D75723272 |
d1ce27f to 8048337 Compare This pull request was exported from Phabricator. Differential Revision: D75723272 |
aporialiao added a commit to aporialiao/torchrec that referenced this pull request Jun 14, 2025
Summary: Pull Request resolved: pytorch#3092 Adding the planner input context has to the sharding plan name that's uploaded to manifold. We will use this hash in the next diff to validate that the sharding plan loaded from manifold was generated with the same inputs as the model that it's being loaded for. Reviewed By: micrain Differential Revision: D75723272
8048337 to aee1fa6 Compare This pull request was exported from Phabricator. Differential Revision: D75723272 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D75723272 |
Differential Revision: D76303748
Summary: Pull Request resolved: pytorch#3092 Adding the planner input context has to the sharding plan name that's uploaded to manifold. We will use this hash in the next diff to validate that the sharding plan loaded from manifold was generated with the same inputs as the model that it's being loaded for. Reviewed By: micrain Differential Revision: D75723272
This pull request was exported from Phabricator. Differential Revision: D75723272 |
aee1fa6 to 0dd313b Compare Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary: Adding the planner input context has to the sharding plan name that's uploaded to manifold. We will use this hash in the next diff to validate that the sharding plan loaded from manifold was generated with the same inputs as the model that it's being loaded for.
Reviewed By: micrain
Differential Revision: D75723272