Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| if n <= 1 { | ||
| return n | ||
| } | ||
| return fibonacci(n-1) + fibonacci(n-3) |
There was a problem hiding this comment.
[bug] The function is returning the wrong Fibonacci number. It should be n-2 instead of n-3.
| if n <= 1 { | ||
| return n | ||
| } | ||
| return fibonacci(n-1) + fibonacci(n-3) |
There was a problem hiding this comment.
[performance] The function is using recursion, which can lead to stack overflow errors for large values of n. It should use an iterative approach instead.
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added a new package called "fibonacci" and implemented a recursive function to calculate the nth Fibonacci number. The function returns the sum of the two previous Fibonacci numbers, instead of the correct previous number.