Conversation

ishitatsuyuki

The state IDs were not remapped, which will usually result in an index out of range error.

@BurntSushi

Is it possible to add a regression test?

@ishitatsuyuki

Sure, let me give it a try tomorrow (it's late here today).

@ishitatsuyuki

Hi, I added a test based on examples in Automaton::is_special_state. I'm asserting that the initial state is .is_start_state(), but this seems to be broken for some reason. Could you help figuring out why? I'm afraid I'm not familiar enough with how the start state ranges are being assigned.

@ishitatsuyuki

Alternatively, I could remove the assert for now and file an issue for it to be fixed later.

@ishitatsuyuki
automata: Fix broken universal start states with sparse DFA
35cee1b
The state IDs were not remapped, which will usually result in an index
out of range error.

Add a test based on is_special_state's doctest, which will validate the
start state's behavior with a custom searcher.
@ishitatsuyuki

It looks like start states were simply being removed with set_no_special_start_states, so this was the intended behavior. I have removed the assert now. Let me know if the tests look good to you.

@ishitatsuyuki

Hi, mind giving this a review?

@ishitatsuyuki

Friendly ping, let me know if there's something else I need to address

Sign up for free to join this conversation on . Already have an account? Sign in to comment
No reviews
No one assigned
None yet
None yet
No milestone

Successfully merging this pull request may close these issues.