Conversation

honeyspoon

fixes #14869

changelog: stop triggering similar_names for 3-character names

Added a simple check if both chars are of length 3
If they are, we skip the check for that pair.

This won't handle the 4 v 3 case.
Not sure if this was the intent of the issue.

Also saw we have some hardcoded exemptions for set, get and lhs, rhs
Tried removing them thinking they would be handled by the new condition.
But we have to keep because they allow for bla_lhs v bla_rhs to be skipped

@rustbot

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added the S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested partieslabel Jun 22, 2025
Sign up for free to join this conversation on . Already have an account? Sign in to comment
S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties
None yet

Successfully merging this pull request may close these issues.

Stop triggering similar_names for 3-character names