Conversation

JustinGrote
  • Align PsesLogLevel to MEL log levels
  • Adjust some logging verbosity levels for the PSES startup logging flow to move better.
  • Create a new LSP Log Debug Provider to get around limitations with the CSharp Omnisharp one.
  • Drop all Omnisharp logs to trace since they are just LSP related
  • Address LSP bugs by wiring up log levels in-band.

Should be merged with PowerShell/vscode-powershell#5065

@JustinGroteJustinGrote requested a review from a team as a code owner November 15, 2024 04:24
@JustinGroteJustinGrote self-assigned this Nov 15, 2024
@JustinGroteJustinGrote marked this pull request as draft November 15, 2024 04:24
@JustinGroteJustinGrote mentioned this pull request Nov 15, 2024
Merged
@JustinGroteJustinGrote changed the title Enhance logging configuration and levels Enhanced Logging Nov 15, 2024
@JustinGroteJustinGrote marked this pull request as ready for review November 15, 2024 06:55
andyleejordan
andyleejordan approved these changes Nov 15, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you want to get this into the upcoming preview?

@andyleejordanandyleejordan merged commit 9ce8911 into main Nov 15, 2024
8 checks passed
@andyleejordanandyleejordan deleted the feature/logImprovements branch November 15, 2024 21:55
@andyleejordanandyleejordan added the Issue-EnhancementA feature request (enhancement).label Nov 15, 2024
This was referencedNov 15, 2024
Closed
Closed
@notpeternotpeter mentioned this pull request May 1, 2025
Closed
This was referencedJun 21, 2025
Open
Open
Sign up for free to join this conversation on . Already have an account? Sign in to comment

@andyleejordan andyleejordan andyleejordan approved these changes

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience

@JustinGrote JustinGrote

Issue-EnhancementA feature request (enhancement).
None yet
No milestone

Successfully merging this pull request may close these issues.