Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Implements the
LogOutputWindow
vscode API for PowerShell extension and PSES logs received via LSP.Recording.2024-10-18.170017.mp4
There will now be 3 separate log output panels:
PowerShell
Messages logged for the PowerShell client and messages sent via the LSP adapter (prepended with [PSES])PowerShell: Trace LSP
Traces the LSP messages back and forth. Omnisharp messages will show up as traces herePowerShell: Trace DAP
Traces the DAP messages back and forth (already implemented)This has several benefits:
Issue Reporter
, there's a contribution API for issue reporter where we can gather additional data as well (PR forthcoming)Log windows do not appear unless enabled.
Right now the Log Verbosity with "Set Log Level" only controls the client-side logging level, but I hope in a future PR to be able to update the logging level of PSES dynamically. Has a minor LSP performance benefit but difficult to implement due to MEL not having dynamic log level change support natively, but I think I found a way with IOptionsMonitor to do it.
Should be merged with PowerShell/PowerShellEditorServices#2200
Fixes #5079