Conversation
|
Vertex AI Mock Responses Check |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
09ccd0e
to 3948d62
Compare fb70a71
to 41ad562
Compare d03fc34
to 978f78f
Compare * Throw not supported exception in _performApiRequest
3948d62
to 14eb393
Compare @@ -28,7 +28,7 @@ export interface ExchangeTokenRequest { | |||
export interface ExchangeTokenRespose { | |||
accessToken: string; | |||
expiresIn?: string; | |||
expiresInSec: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not store this as a Number instead of string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also shouldn't the name match the backend name? https://source.corp.google.com/piper///depot/google3/google/cloud/identityplatform/v2main/token_exchange_service.proto;l=85?q=%20%22exchangeOidcToken%22
@@ -621,6 +629,11 @@ export class AuthImpl implements AuthInternal, _FirebaseService { | |||
} | |||
} | |||
async getTokenForRegionalAuth(): | |||
Promise<string> { | |||
if (Date.now() > this.tokenResponse?.expiresIn) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks incomplete
Discussion
Testing