Conversation

mansisampat

Discussion

  • Writes BYO-CIAM access token, expiresIn to the Auth Object Initialized.

Testing

  • Unit Test added

@changeset-botchangeset-bot

⚠️No Changeset found

Latest commit: 14eb393

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actionsGitHub Actions

Vertex AI Mock Responses Check⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@google-oss-bot

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (fb70a71)Merge (b730b95)Diff
    browser195 kB196 kB+221 B (+0.1%)
    cordova168 kB168 kB+221 B (+0.1%)
    main150 kB150 kB+221 B (+0.1%)
    module195 kB196 kB+221 B (+0.1%)
    react-native168 kB168 kB+221 B (+0.1%)
  • @firebase/auth-cordova

    TypeBase (fb70a71)Merge (b730b95)Diff
    browser168 kB168 kB+221 B (+0.1%)
    module168 kB168 kB+221 B (+0.1%)
  • @firebase/auth-web-extension

    TypeBase (fb70a71)Merge (b730b95)Diff
    browser145 kB145 kB+221 B (+0.2%)
    main162 kB162 kB+221 B (+0.1%)
    module145 kB145 kB+221 B (+0.2%)
  • @firebase/auth/internal

    TypeBase (fb70a71)Merge (b730b95)Diff
    browser206 kB206 kB+221 B (+0.1%)
    main176 kB176 kB+221 B (+0.1%)
    module206 kB206 kB+221 B (+0.1%)
  • bundle

    TypeBase (fb70a71)Merge (b730b95)Diff
    auth (Anonymous)78.2 kB78.3 kB+82 B (+0.1%)
    auth (EmailAndPassword)88.4 kB88.4 kB+82 B (+0.1%)
    auth (GoogleFBTwitterPopup)110 kB110 kB+82 B (+0.1%)
    auth (GooglePopup)102 kB102 kB+82 B (+0.1%)
    auth (GoogleRedirect)102 kB103 kB+82 B (+0.1%)
    auth (Phone)95.8 kB95.9 kB+82 B (+0.1%)
  • firebase

    TypeBase (fb70a71)Merge (b730b95)Diff
    firebase-auth-compat.js146 kB146 kB+80 B (+0.1%)
    firebase-auth-cordova.js144 kB144 kB+160 B (+0.1%)
    firebase-auth-web-extension.js127 kB127 kB+160 B (+0.1%)
    firebase-auth.js164 kB165 kB+160 B (+0.1%)
    firebase-compat.js803 kB803 kB+80 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/k3sJKhEEEm.html

@google-oss-bot

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • ActionCodeOperation

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.1 kB41.2 kB+82 B (+0.2%)
      size-with-ext-deps63.1 kB63.2 kB+82 B (+0.1%)
    • ActionCodeURL

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.9 kB42.0 kB+82 B (+0.2%)
      size-with-ext-deps64.2 kB64.3 kB+82 B (+0.1%)
    • AuthCredential

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.1 kB41.2 kB+82 B (+0.2%)
      size-with-ext-deps63.2 kB63.2 kB+82 B (+0.1%)
    • AuthErrorCodes

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size46.0 kB46.1 kB+82 B (+0.2%)
      size-with-ext-deps68.1 kB68.2 kB+82 B (+0.1%)
    • EmailAuthCredential

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size48.7 kB48.8 kB+82 B (+0.2%)
      size-with-ext-deps70.7 kB70.8 kB+82 B (+0.1%)
    • EmailAuthProvider

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size50.1 kB50.2 kB+82 B (+0.2%)
      size-with-ext-deps72.4 kB72.5 kB+82 B (+0.1%)
    • FacebookAuthProvider

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size45.9 kB46.0 kB+82 B (+0.2%)
      size-with-ext-deps68.0 kB68.0 kB+82 B (+0.1%)
    • FactorId

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.9 kB41.0 kB+82 B (+0.2%)
      size-with-ext-deps62.9 kB63.0 kB+82 B (+0.1%)
    • AuthProvider

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size45.9 kB46.0 kB+82 B (+0.2%)
      size-with-ext-deps68.0 kB68.0 kB+82 B (+0.1%)
    • GoogleAuthProvider

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size45.9 kB46.0 kB+82 B (+0.2%)
      size-with-ext-deps68.0 kB68.0 kB+82 B (+0.1%)
    • OAuthCredential

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size43.0 kB43.1 kB+82 B (+0.2%)
      size-with-ext-deps65.1 kB65.1 kB+82 B (+0.1%)
    • OAuthProvider

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size46.8 kB46.9 kB+82 B (+0.2%)
      size-with-ext-deps68.9 kB69.0 kB+82 B (+0.1%)
    • OperationType

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.9 kB41.0 kB+82 B (+0.2%)
      size-with-ext-deps63.0 kB63.0 kB+82 B (+0.1%)
    • PhoneAuthCredential

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size43.0 kB43.1 kB+82 B (+0.2%)
      size-with-ext-deps65.1 kB65.1 kB+82 B (+0.1%)
    • PhoneAuthProvider

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size52.3 kB52.4 kB+82 B (+0.2%)
      size-with-ext-deps74.4 kB74.5 kB+82 B (+0.1%)
    • PhoneMultiFactorGenerator

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.7 kB41.8 kB+82 B (+0.2%)
      size-with-ext-deps63.8 kB63.8 kB+82 B (+0.1%)
    • ProviderId

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.0 kB41.0 kB+82 B (+0.2%)
      size-with-ext-deps63.0 kB63.1 kB+82 B (+0.1%)
    • RecaptchaVerifier

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size47.8 kB47.9 kB+82 B (+0.2%)
      size-with-ext-deps69.9 kB70.0 kB+82 B (+0.1%)
    • SAMLAuthProvider

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size47.2 kB47.2 kB+82 B (+0.2%)
      size-with-ext-deps69.2 kB69.3 kB+82 B (+0.1%)
    • SignInMethod

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.0 kB41.1 kB+82 B (+0.2%)
      size-with-ext-deps63.0 kB63.1 kB+82 B (+0.1%)
    • TotpMultiFactorGenerator

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size43.4 kB43.4 kB+82 B (+0.2%)
      size-with-ext-deps65.4 kB65.5 kB+82 B (+0.1%)
    • TotpSecret

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.8 kB41.9 kB+82 B (+0.2%)
      size-with-ext-deps63.9 kB63.9 kB+82 B (+0.1%)
    • TwitterAuthProvider

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size45.9 kB46.0 kB+82 B (+0.2%)
      size-with-ext-deps68.0 kB68.0 kB+82 B (+0.1%)
    • applyActionCode

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.0 kB41.0 kB+82 B (+0.2%)
      size-with-ext-deps63.0 kB63.1 kB+82 B (+0.1%)
    • beforeAuthStateChanged

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.9 kB41.0 kB+82 B (+0.2%)
      size-with-ext-deps63.0 kB63.0 kB+82 B (+0.1%)
    • browserCookiePersistence

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size42.8 kB42.9 kB+82 B (+0.2%)
      size-with-ext-deps64.8 kB64.9 kB+82 B (+0.1%)
    • browserLocalPersistence

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size43.9 kB44.0 kB+82 B (+0.2%)
      size-with-ext-deps66.0 kB66.1 kB+82 B (+0.1%)
    • browserPopupRedirectResolver

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size65.4 kB65.5 kB+82 B (+0.1%)
      size-with-ext-deps87.7 kB87.8 kB+82 B (+0.1%)
    • browserSessionPersistence

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size43.9 kB44.0 kB+82 B (+0.2%)
      size-with-ext-deps66.0 kB66.1 kB+82 B (+0.1%)
    • checkActionCode

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size42.1 kB42.2 kB+82 B (+0.2%)
      size-with-ext-deps64.1 kB64.2 kB+82 B (+0.1%)
    • confirmPasswordReset

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.2 kB41.3 kB+82 B (+0.2%)
      size-with-ext-deps63.2 kB63.3 kB+82 B (+0.1%)
    • connectAuthEmulator

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size42.8 kB42.9 kB+82 B (+0.2%)
      size-with-ext-deps69.6 kB69.7 kB+82 B (+0.1%)
    • createUserWithEmailAndPassword

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size47.8 kB47.9 kB+82 B (+0.2%)
      size-with-ext-deps69.9 kB70.0 kB+82 B (+0.1%)
    • debugErrorMap

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size53.3 kB53.4 kB+82 B (+0.2%)
      size-with-ext-deps75.3 kB75.4 kB+82 B (+0.1%)
    • deleteUser

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.9 kB41.0 kB+82 B (+0.2%)
      size-with-ext-deps62.9 kB63.0 kB+82 B (+0.1%)
    • exchangeToken

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.6 kB41.8 kB+162 B (+0.4%)
      size-with-ext-deps63.7 kB63.8 kB+162 B (+0.3%)
    • fetchSignInMethodsForEmail

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.2 kB41.3 kB+82 B (+0.2%)
      size-with-ext-deps63.2 kB63.3 kB+82 B (+0.1%)
    • getAdditionalUserInfo

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size42.2 kB42.3 kB+82 B (+0.2%)
      size-with-ext-deps64.2 kB64.3 kB+82 B (+0.1%)
    • getAuth

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size75.9 kB76.0 kB+82 B (+0.1%)
      size-with-ext-deps109 kB109 kB+82 B (+0.1%)
    • getIdToken

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.9 kB41.0 kB+82 B (+0.2%)
      size-with-ext-deps62.9 kB63.0 kB+82 B (+0.1%)
    • getIdTokenResult

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.8 kB40.9 kB+82 B (+0.2%)
      size-with-ext-deps62.9 kB63.0 kB+82 B (+0.1%)
    • getMultiFactorResolver

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size43.7 kB43.8 kB+82 B (+0.2%)
      size-with-ext-deps65.8 kB65.9 kB+82 B (+0.1%)
    • getRedirectResult

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size48.5 kB48.6 kB+82 B (+0.2%)
      size-with-ext-deps70.6 kB70.7 kB+82 B (+0.1%)
    • inMemoryPersistence

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.8 kB40.9 kB+82 B (+0.2%)
      size-with-ext-deps62.9 kB63.0 kB+82 B (+0.1%)
    • indexedDBLocalPersistence

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size48.3 kB48.4 kB+82 B (+0.2%)
      size-with-ext-deps70.3 kB70.4 kB+82 B (+0.1%)
    • initializeAuth

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.1 kB41.2 kB+82 B (+0.2%)
      size-with-ext-deps63.6 kB63.7 kB+82 B (+0.1%)
    • initializeRecaptchaConfig

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size44.6 kB44.7 kB+82 B (+0.2%)
      size-with-ext-deps66.7 kB66.7 kB+82 B (+0.1%)
    • isSignInWithEmailLink

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size42.0 kB42.1 kB+82 B (+0.2%)
      size-with-ext-deps64.3 kB64.4 kB+82 B (+0.1%)
    • linkWithCredential

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.9 kB42.0 kB+82 B (+0.2%)
      size-with-ext-deps63.9 kB64.0 kB+82 B (+0.1%)
    • linkWithPhoneNumber

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size53.1 kB53.2 kB+82 B (+0.2%)
      size-with-ext-deps75.2 kB75.2 kB+82 B (+0.1%)
    • linkWithPopup

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size52.0 kB52.1 kB+82 B (+0.2%)
      size-with-ext-deps74.1 kB74.2 kB+82 B (+0.1%)
    • linkWithRedirect

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size47.2 kB47.3 kB+82 B (+0.2%)
      size-with-ext-deps69.3 kB69.3 kB+82 B (+0.1%)
    • multiFactor

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size43.1 kB43.1 kB+82 B (+0.2%)
      size-with-ext-deps65.1 kB65.2 kB+82 B (+0.1%)
    • onAuthStateChanged

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.9 kB41.0 kB+82 B (+0.2%)
      size-with-ext-deps63.0 kB63.0 kB+82 B (+0.1%)
    • onIdTokenChanged

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.9 kB41.0 kB+82 B (+0.2%)
      size-with-ext-deps62.9 kB63.0 kB+82 B (+0.1%)
    • parseActionCodeURL

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size42.0 kB42.0 kB+82 B (+0.2%)
      size-with-ext-deps64.3 kB64.3 kB+82 B (+0.1%)
    • prodErrorMap

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.8 kB40.9 kB+82 B (+0.2%)
      size-with-ext-deps62.9 kB63.0 kB+82 B (+0.1%)
    • reauthenticateWithCredential

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size42.5 kB42.6 kB+82 B (+0.2%)
      size-with-ext-deps64.5 kB64.6 kB+82 B (+0.1%)
    • reauthenticateWithPhoneNumber

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size53.7 kB53.8 kB+82 B (+0.2%)
      size-with-ext-deps75.8 kB75.9 kB+82 B (+0.1%)
    • reauthenticateWithPopup

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size52.2 kB52.2 kB+82 B (+0.2%)
      size-with-ext-deps74.2 kB74.3 kB+82 B (+0.1%)
    • reauthenticateWithRedirect

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size47.0 kB47.1 kB+82 B (+0.2%)
      size-with-ext-deps69.1 kB69.1 kB+82 B (+0.1%)
    • reload

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.8 kB40.9 kB+82 B (+0.2%)
      size-with-ext-deps62.9 kB63.0 kB+82 B (+0.1%)
    • revokeAccessToken

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.9 kB41.0 kB+82 B (+0.2%)
      size-with-ext-deps63.0 kB63.0 kB+82 B (+0.1%)
    • sendEmailVerification

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.9 kB42.0 kB+82 B (+0.2%)
      size-with-ext-deps64.0 kB64.0 kB+82 B (+0.1%)
    • sendPasswordResetEmail

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size47.5 kB47.6 kB+82 B (+0.2%)
      size-with-ext-deps69.6 kB69.6 kB+82 B (+0.1%)
    • sendSignInLinkToEmail

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size47.6 kB47.6 kB+82 B (+0.2%)
      size-with-ext-deps69.6 kB69.7 kB+82 B (+0.1%)
    • setPersistence

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.9 kB41.0 kB+82 B (+0.2%)
      size-with-ext-deps62.9 kB63.0 kB+82 B (+0.1%)
    • signInAnonymously

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size42.1 kB42.1 kB+82 B (+0.2%)
      size-with-ext-deps64.1 kB64.2 kB+82 B (+0.1%)
    • signInWithCredential

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size42.3 kB42.4 kB+82 B (+0.2%)
      size-with-ext-deps64.3 kB64.4 kB+82 B (+0.1%)
    • signInWithCustomToken

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.9 kB42.0 kB+82 B (+0.2%)
      size-with-ext-deps64.0 kB64.0 kB+82 B (+0.1%)
    • signInWithEmailAndPassword

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size51.8 kB51.9 kB+82 B (+0.2%)
      size-with-ext-deps74.2 kB74.2 kB+82 B (+0.1%)
    • signInWithEmailLink

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size51.8 kB51.9 kB+82 B (+0.2%)
      size-with-ext-deps74.2 kB74.2 kB+82 B (+0.1%)
    • signInWithPhoneNumber

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size53.5 kB53.6 kB+82 B (+0.2%)
      size-with-ext-deps75.6 kB75.7 kB+82 B (+0.1%)
    • signInWithPopup

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size52.1 kB52.2 kB+82 B (+0.2%)
      size-with-ext-deps74.2 kB74.3 kB+82 B (+0.1%)
    • signInWithRedirect

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size46.7 kB46.8 kB+82 B (+0.2%)
      size-with-ext-deps68.8 kB68.8 kB+82 B (+0.1%)
    • signOut

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.9 kB40.9 kB+82 B (+0.2%)
      size-with-ext-deps62.9 kB63.0 kB+82 B (+0.1%)
    • unlink

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.4 kB41.5 kB+82 B (+0.2%)
      size-with-ext-deps63.5 kB63.6 kB+82 B (+0.1%)
    • updateCurrentUser

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.9 kB41.0 kB+82 B (+0.2%)
      size-with-ext-deps62.9 kB63.0 kB+82 B (+0.1%)
    • updateEmail

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.2 kB41.3 kB+82 B (+0.2%)
      size-with-ext-deps63.3 kB63.4 kB+82 B (+0.1%)
    • updatePassword

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.2 kB41.2 kB+82 B (+0.2%)
      size-with-ext-deps63.2 kB63.3 kB+82 B (+0.1%)
    • updatePhoneNumber

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.7 kB41.7 kB+82 B (+0.2%)
      size-with-ext-deps63.7 kB63.8 kB+82 B (+0.1%)
    • updateProfile

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.3 kB41.4 kB+82 B (+0.2%)
      size-with-ext-deps63.4 kB63.5 kB+82 B (+0.1%)
    • useDeviceLanguage

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.9 kB41.0 kB+82 B (+0.2%)
      size-with-ext-deps62.9 kB63.0 kB+82 B (+0.1%)
    • validatePassword

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size40.9 kB41.0 kB+82 B (+0.2%)
      size-with-ext-deps63.0 kB63.0 kB+82 B (+0.1%)
    • verifyBeforeUpdateEmail

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size41.9 kB42.0 kB+82 B (+0.2%)
      size-with-ext-deps64.0 kB64.1 kB+82 B (+0.1%)
    • verifyPasswordResetCode

      Size

      TypeBase (fb70a71)Merge (b730b95)Diff
      size42.2 kB42.2 kB+82 B (+0.2%)
      size-with-ext-deps64.2 kB64.3 kB+82 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LawRpm5AS6.html

@mansisampatmansisampat force-pushed the sammansi-gcip-byociam-web-interop branch from 09ccd0e to 3948d62 Compare May 19, 2025 06:05
@mansisampatmansisampat force-pushed the sammansi-gcip-byociam-web branch from fb70a71 to 41ad562 Compare May 19, 2025 06:08
@mansisampatmansisampat marked this pull request as draft May 19, 2025 06:17
@mansisampatmansisampat force-pushed the sammansi-gcip-byociam-web branch from d03fc34 to 978f78f Compare May 22, 2025 05:06
@mansisampatmansisampat force-pushed the sammansi-gcip-byociam-web-interop branch from 3948d62 to 14eb393 Compare May 22, 2025 05:28
@@ -28,7 +28,7 @@ export interface ExchangeTokenRequest {

export interface ExchangeTokenRespose {
accessToken: string;
expiresIn?: string;
expiresInSec: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not store this as a Number instead of string?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -621,6 +629,11 @@ export class AuthImpl implements AuthInternal, _FirebaseService {
}
}

async getTokenForRegionalAuth():
Promise<string> {
if (Date.now() > this.tokenResponse?.expiresIn)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks incomplete

Base automatically changed from sammansi-gcip-byociam-web to gcip-byociam-web May 23, 2025 06:18
Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.