Draft
Changes from 1 commit
Show all changes
18 commitsSelect commit Hold shift + click to select a range
a8426a6
GCIP BYO-CIAM Initialize Auth Changes (#8995)
mansisampatc02ca13
Throw Operation Not Allowed for Invalid Auth Endpoint (#9013)
mansisampata3dc91a
Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019)
mansisampat54db430
Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019)
mansisampat251353f
Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019)
mansisampat8690a01
Implement exchangeToken public api
mansisampat8965130
Using expiry_in returned by backend
mansisampat978f78f
Addressing review comments and adding some Unit test
mansisampatd9ef125
Docgen
mansisampatff61e6c
Throw Operation Not Allowed for Invalid Auth Endpoint (#9013)
mansisampat537bdc6
Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019)
mansisampatc0cc6eb
Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019)
mansisampatb609765
Implement exchangeToken public api
mansisampat28ccf1e
Write BYO-CIAM token, expiresIn to the Auth Object initialized
mansisampatccd5174
Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019)
mansisampata361d46
Throw Operation Not Allowed for Invalid Auth Endpoint (#9013) (#9019)
mansisampat7ca7909
yarn docgen:all
mansisampat14eb393
Exchange Token interop changes
mansisampatFile filter
Filter by extension
Conversations
Failed to load comments.
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Failed to load files.
Uh oh!
There was an error while loading. Please reload this page.
PrevPrevious commit
Exchange Token interop changes
- Loading branch information
Uh oh!
There was an error while loading. Please reload this page.
commit 14eb3932773565246a8f6ea028b24c71d5452228
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -629,6 +629,11 @@ export class AuthImpl implements AuthInternal, _FirebaseService { | ||
} | ||
} | ||
async getTokenForRegionalAuth(): | ||
Promise<string> { | ||
if (Date.now() > this.tokenResponse?.expiresIn) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This looks incomplete | ||
} | ||
toJSON(): object { | ||
return { | ||
apiKey: this.config.apiKey, | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not store this as a Number instead of string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also shouldn't the name match the backend name? https://source.corp.google.com/piper///depot/google3/google/cloud/identityplatform/v2main/token_exchange_service.proto;l=85?q=%20%22exchangeOidcToken%22