Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…16566) Extracted out from #16565 I noticed that our `modulesIntegration` is pretty limited: 1. It does nothing on EMS 2. It does not work on Next.js (even though that is CJS) This PR makes this a bit more robust (not perfect): 1. It generally now also tries to look at `process.cwd() + 'package.json'` and take the dependencies and devDependencies from there. this should generally work in esm apps now as well, at least at a basic level. You do not get all dependencies and versions may be ranges, but better than nothing. 2. For Next.js, we inject a modules list based off the package.json at build time, as we do not have proper access to this at runtime.
[Gitflow] Merge master into develop
…le is detected (#16565) This PR improves the handling of the `ai` instrumentation to always be enabled when we detect the `ai` module is installed. For this, we leverage the `modulesIntegration`. This PR should make usage of ai instrumentation in Next.js "automatically" again - BUT users will have to specific ` experimental_telemetry: { isEnabled: true },` at each call manually for the time being. --------- Co-authored-by: Cursor Agent <[email protected]>
…16557) resolves #16237 In #16348 we had to revert the PR that added `detail` to `measure` spans as attributes. measure API: https://developer.mozilla.org/en-US/docs/Web/API/Performance/measure detail: https://developer.mozilla.org/en-US/docs/Web/API/PerformanceMeasure/detail This was [reverted](#16347) because it was causing issues in firefox, specifically this error was being thrown ``` Error: Permission denied to access object at _addMeasureSpans(../../node_modules/@sentry-internal/browser-utils/build/esm/metrics/browserMetrics.js:255:41) at X2e/<(../../node_modules/@sentry-internal/browser-utils/build/esm/metrics/browserMetrics.js:194:9) at addPerformanceEntries(../../node_modules/@sentry-internal/browser-utils/build/esm/metrics/browserMetrics.js:174:48) at idleSpan.beforeSpanEnd(../../node_modules/@sentry/browser/build/npm/esm/tracing/browserTracingIntegration.js:90:9) at span.endapply(../../node_modules/@sentry/browser/node_modules/@sentry/core/build/esm/tracing/idleSpan.js:52:9) at Coe/<(../../node_modules/@sentry/browser/node_modules/@sentry/core/build/esm/tracing/idleSpan.js:196:12) at sentryWrapped(../../node_modules/@sentry/browser/build/npm/esm/helpers.js:38:17) ``` From debugging, this seems to be coming from a `DOMException` being thrown @https://developer.mozilla.org/en-US/docs/Web/API/DOMException This was re-implemented, and then we added tests to validate that this wouldn't break on firefox. --------- Co-authored-by: Cursor Agent <[email protected]>
…#16552) So they can be instrumented by us. I think this should be fine and not really affect users, hopefully, since Next.js itself also does this already for common packages. Closes #16550 --------- Co-authored-by: Charly Gomez <[email protected]>
…#16590) Noticed this small but potentially impactful typo: We used to mark all finished spans as sent, not just the ones that are actually sent :O (Also we iterated twice over the same array, streamlined this by just doing this once).
…ctions issues (#16500) Next.js’s uses an internal AsyncLocalStorage (ALS) to share minimal request context—it deliberately does not populate the full Request object or URL in ALS, so only headers (Referer, x-forwarded-host, x-forwarded-proto) are available at runtime in Server Components. To still capture a usable URL for metadata we use a three-step best-effort fallback: 1. `Referer` header Use it as the fully qualified URL if present (note: this could be omitted by the browser). 2. Proxy headers + route Reconstruct protocol://host from x-forwarded-proto / x-forwarded-host (or host), then append the normalized component route with substituted [param] values. Query strings and fragments are TBD as query params fetched from args are always undefined for some reason, this needs investigation 3. Span fallback As a last resort, use the parent span’s http.target attribute (which contains the path and query) from the root HTTP span. <img width="1261" alt="Screenshot 2025-06-02 at 4 04 31 PM" src="https://.com/user-attachments/assets/0cebe68a-89e7-4b61-9c58-962f8e70c7f9" /> closes: https://linear.app/getsentry/issue/JS-487/capture-requesturl-for-nextjs-server-spans
size-limit report 📦
|
❌ Unsupported file format
|
AbhiPrasad approved these changes Jun 16, 2025
009acbd into master 164 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.