Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rven1 reviewed May 13, 2020
| client | ||
| .singleUse() | ||
| .executeQuery(Statement.of("SELECT 1 AS COL1 UNION ALL SELECT 2 AS COL2"))) { | ||
| assertThat(rs.next()).isTrue(); |
There was a problem hiding this comment.
Would it be possible to test an end to end compression and verify that the compressor is actually used.
There was a problem hiding this comment.
Yes absolutely. Once the support is in the staging environment, we can run this IT against it to test the change. @olavloite I'll give you a heads up when the feature is available in staging.
skuruppu approved these changes Jun 23, 2020
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java Outdated Show resolved Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
@olavloite we can merge this change now. If you can resolve the conflict and merge, that would be great. |
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 7, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.58.0](https://www..com/googleapis/java-spanner/compare/v1.57.0...v1.58.0) (2020-07-07) ### Features * add async api ([#81](https://www..com/googleapis/java-spanner/issues/81)) ([462839b](https://www..com/googleapis/java-spanner/commit/462839b625e58e235581b8ba10b398e1d222eaaf)) * support setting compression option ([#192](https://www..com/googleapis/java-spanner/issues/192)) ([965e95e](https://www..com/googleapis/java-spanner/commit/965e95e70ccd9c62abd6513b0011aab136e48e26)) ### Bug Fixes * set default values for retry ([#316](https://www..com/googleapis/java-spanner/issues/316)) ([543373b](https://www..com/googleapis/java-spanner/commit/543373b22336be72b10026fda9f0b55939ab94b4)) ### Performance Improvements * use RPC for PDML ([#287](https://www..com/googleapis/java-spanner/issues/287)) ([df47c13](https://www..com/googleapis/java-spanner/commit/df47c13a4c00bdf5e6eafa01bbb64c12a96d7fb8)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.2 ([#315](https://www..com/googleapis/java-spanner/issues/315)) ([3d6fb9f](https://www..com/googleapis/java-spanner/commit/3d6fb9fd7dc6b2b5b2ff9935228701ac795c9167)) --- This PR was generated with [Release Please](https://.com/googleapis/release-please).
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This reverts commit googleapis#191 .
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds support for setting the compressor to use for gRPC calls.