Merged

feat: support setting compression option #192

Changes from 1 commit
Show all changes
6 commits
Select commit Hold shift + click to select a range
7244291
feat: support setting compression option
olavloiteMay 6, 2020
73dfbc8
fix: use correct encoding header
olavloiteJun 17, 2020
193dfee
fix: add project id
olavloiteJun 17, 2020
eb967c6
docs: fix typo + missing end tag
olavloiteJun 23, 2020
2435e88
chore: resolve merge conflicts
olavloiteJun 30, 2020
afbd975
tests: fix test failure on emulator
olavloiteJun 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Failed to load files.
PrevPrevious commit
Next Next commit
fix: add project id
  • Loading branch information
@olavloite
olavloite committedJun 30, 2020
commit 193dfee0a32dd24491c26e405752e1284f9e8290
Original file line numberDiff line numberDiff line change
Expand Up@@ -508,12 +508,26 @@ public String getOptimizerVersion() {

@Test
public void testCompressorName() {
assertThat(SpannerOptions.newBuilder().setCompressorName("gzip").build().getCompressorName())
assertThat(
SpannerOptions.newBuilder()
.setProjectId("p")
.setCompressorName("gzip")
.build()
.getCompressorName())
.isEqualTo("gzip");
assertThat(
SpannerOptions.newBuilder().setCompressorName("identity").build().getCompressorName())
SpannerOptions.newBuilder()
.setProjectId("p")
.setCompressorName("identity")
.build()
.getCompressorName())
.isEqualTo("identity");
assertThat(SpannerOptions.newBuilder().setCompressorName(null).build().getCompressorName())
assertThat(
SpannerOptions.newBuilder()
.setProjectId("p")
.setCompressorName(null)
.build()
.getCompressorName())
.isNull();
try {
SpannerOptions.newBuilder().setCompressorName("foo");
Expand Down