Conversation

TheChymera

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@TheChymera

@effigies can I merge to master now that you've approved?

@effigies

I've restarted the tests to make sure they pass. But yeah, when tests pass, that's fine with me.

@codecov-io

Codecov Report

Merging #2869 into master will decrease coverage by 3.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2869      +/-   ##
==========================================
- Coverage   67.49%   64.11%   -3.39%     
==========================================
  Files         342      340       -2     
  Lines       43562    43507      -55     
  Branches     5422     5419       -3     
==========================================
- Hits        29404    27894    -1510     
- Misses      13447    14541    +1094     
- Partials      711     1072     +361
FlagCoverage Δ
#smoketests?
#unittests64.11% <ø> (-0.82%)⬇️
Impacted FilesCoverage Δ
nipype/interfaces/ants/registration.py73.92% <ø> (ø)⬆️
nipype/interfaces/nilearn.py40% <0%> (-56.67%)⬇️
nipype/utils/spm_docs.py25.92% <0%> (-44.45%)⬇️
nipype/interfaces/freesurfer/base.py50% <0%> (-30.51%)⬇️
nipype/utils/logger.py59.7% <0%> (-29.86%)⬇️
nipype/algorithms/rapidart.py35% <0%> (-29.42%)⬇️
nipype/interfaces/spm/base.py58.08% <0%> (-29.05%)⬇️
nipype/utils/provenance.py55.73% <0%> (-28.99%)⬇️
nipype/interfaces/fsl/model.py55.26% <0%> (-25.35%)⬇️
nipype/testing/fixtures.py77.33% <0%> (-21.34%)⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a3ea3...28a943a. Read the comment docs.

@effigieseffigies changed the title DOC: typos and spacing DOC: Fix typos in ANTs Registration input documentation Jan 30, 2019
@effigieseffigies merged commit 98beb0a into nipy:master Jan 30, 2019
@TheChymeraTheChymera deleted the typos branch January 30, 2019 20:31
yarikoptic added a commit to yarikoptic/nipype that referenced this pull request Mar 15, 2019
1.1.9 (February 25, 2019)

Full changelog: https://.com/nipy/nipype/milestone/30?closed=1

  * FIX: Make positional arguments to LaplacianThickness require previous argument (nipy#2848)
  * FIX: Import math and csv modules for bids_gen_info (nipy#2881)
  * FIX: Ensure outputs can be listed in camino.ProcStreamlines by defining instance variable (nipy#2739)
  * ENH: Allow afni.MaskTool to take multiple input files (nipy#2892)
  * ENH: Add flags dictionary input to spm.Level1Design (nipy#2861)
  * ENH: Threshold stddev once only in TSNR (nipy#2883)
  * ENH: Add workbench.CiftiSmooth interface (nipy#2871)
  * DOC: Replace initialism typo in comment with intended phrase (nipy#2875)
  * DOC: Fix typos in ANTs Registration input documentation (nipy#2869)

* tag '1.1.9': (34 commits)
  MNT: Update changelog
  MNT: Add Katherine Bottenhorn, Paul Mihai to Zenodo
  MNT: Add kchawla-pi to Zenodo, update mailmap and ordering
  add to zenodo
  MNT: Update zenodo ordering
  Update .zenodo.json
  afni utils.py - masktool - InputMultiPath for in_file argument
  MNT: Update .zenodo ordering
  MNT: Add Oliver Contier name to .zenodo.json
  Update nipype/interfaces/spm/model.py
  ENH: Add zenodo updating script
  MNT: Update mailmap to avoid renames in script
  MNT: Update .mailmap, .zenodo.json
  MNT: Version 1.1.9
  DOC: 1.1.9 changelog
  ENH: minor - compute non degenerate stddev map once
  BF: regenerated test_auto_LaplacianThickness using wonderfully long running tools/checkspecs.py
  TEST: Thorough test of LaplacianThickness requirement cascade
  FIX: Requires error text was backwards
  import math and csv modules for bids_gen_info
  ...
@effigieseffigies added this to the 1.1.9 milestone Apr 29, 2019
Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.