Conversation

yarikoptic

Just was for some reason looking at that code and spotted wasted cycles

@codecov-io

Codecov Report

Merging #2883 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2883      +/-   ##
==========================================
+ Coverage   67.51%   67.51%   +<.01%     
==========================================
  Files         343      343              
  Lines       43594    43595       +1     
  Branches     5424     5424              
==========================================
+ Hits        29434    29435       +1     
  Misses      13457    13457              
  Partials      703      703
FlagCoverage Δ
#smoketests50.48% <0%> (-0.01%)⬇️
#unittests64.95% <100%> (ø)⬆️
Impacted FilesCoverage Δ
nipype/algorithms/confounds.py66.34% <100%> (+0.06%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 469c99c...c08285c. Read the comment docs.

1 similar comment
@codecov-io

Codecov Report

Merging #2883 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2883      +/-   ##
==========================================
+ Coverage   67.51%   67.51%   +<.01%     
==========================================
  Files         343      343              
  Lines       43594    43595       +1     
  Branches     5424     5424              
==========================================
+ Hits        29434    29435       +1     
  Misses      13457    13457              
  Partials      703      703
FlagCoverage Δ
#smoketests50.48% <0%> (-0.01%)⬇️
#unittests64.95% <100%> (ø)⬆️
Impacted FilesCoverage Δ
nipype/algorithms/confounds.py66.34% <100%> (+0.06%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 469c99c...c08285c. Read the comment docs.

@effigieseffigies changed the title ENH: minor - compute non degenerate stddev map once ENH: Threshold stddev once only in TSNR Feb 20, 2019
@effigieseffigies merged commit efb4645 into nipy:master Feb 20, 2019
@effigieseffigies added this to the 1.1.9 milestone Feb 20, 2019
yarikoptic added a commit to yarikoptic/nipype that referenced this pull request Mar 15, 2019
1.1.9 (February 25, 2019)

Full changelog: https://.com/nipy/nipype/milestone/30?closed=1

  * FIX: Make positional arguments to LaplacianThickness require previous argument (nipy#2848)
  * FIX: Import math and csv modules for bids_gen_info (nipy#2881)
  * FIX: Ensure outputs can be listed in camino.ProcStreamlines by defining instance variable (nipy#2739)
  * ENH: Allow afni.MaskTool to take multiple input files (nipy#2892)
  * ENH: Add flags dictionary input to spm.Level1Design (nipy#2861)
  * ENH: Threshold stddev once only in TSNR (nipy#2883)
  * ENH: Add workbench.CiftiSmooth interface (nipy#2871)
  * DOC: Replace initialism typo in comment with intended phrase (nipy#2875)
  * DOC: Fix typos in ANTs Registration input documentation (nipy#2869)

* tag '1.1.9': (34 commits)
  MNT: Update changelog
  MNT: Add Katherine Bottenhorn, Paul Mihai to Zenodo
  MNT: Add kchawla-pi to Zenodo, update mailmap and ordering
  add to zenodo
  MNT: Update zenodo ordering
  Update .zenodo.json
  afni utils.py - masktool - InputMultiPath for in_file argument
  MNT: Update .zenodo ordering
  MNT: Add Oliver Contier name to .zenodo.json
  Update nipype/interfaces/spm/model.py
  ENH: Add zenodo updating script
  MNT: Update mailmap to avoid renames in script
  MNT: Update .mailmap, .zenodo.json
  MNT: Version 1.1.9
  DOC: 1.1.9 changelog
  ENH: minor - compute non degenerate stddev map once
  BF: regenerated test_auto_LaplacianThickness using wonderfully long running tools/checkspecs.py
  TEST: Thorough test of LaplacianThickness requirement cascade
  FIX: Requires error text was backwards
  import math and csv modules for bids_gen_info
  ...
Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.