Conversation

lbutry

This PR updates the mrtrix3 interface in nipype and closes issue #3612

List of proposed changes:

  1. Added "MaskFilter" for dilate/erode filteres
  2. Added "MTnormalise"
  3. Added "Generate5tt2gmwmi"

@teanijarv

What's the status on this PR? I just found as well that mtnormalise doesn't have interface in nipype.

@dalerxli

This comment was marked as off-topic.

@effigies

Apologies for the delay. Please review the change I made (apart from the merge fixing up Zenodo author ordering) and the CI complaints.

Once the tests are passing and you're okay with this, we can merge.

@codecovCodecov

Codecov Report

Attention: coverage is 78.43137% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 63.16%. Comparing base (f1a8909) to head (27d285a).
Report is 11 commits behind head on master.

❗ Current head 27d285a differs from pull request most recent head 5599348. Consider uploading reports for the commit 5599348 to get more accurate results

Files%Lines
nipype/interfaces/mrtrix3/utils.py78.43%11 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3613      +/-   ##
==========================================
+ Coverage   63.14%   63.16%   +0.01%     
==========================================
  Files         308      308              
  Lines       40824    40875      +51     
  Branches     5655     5655              
==========================================
+ Hits        25780    25820      +40     
- Misses      14031    14042      +11     
  Partials     1013     1013              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbutry

Thank you for reviewing! The changes you made are all good in my opinion.

Unfortunately, I'm rather new to and not familiar with the CI complaints. I won't be able to fix them. I would appreciate it very much if someone could help me out here.

@effigieseffigies merged commit 28973c5 into nipy:master Mar 20, 2024
@effigieseffigies mentioned this pull request Mar 20, 2024
6 tasks
@effigieseffigies mentioned this pull request Oct 31, 2024
6 tasks
Sign up for free to join this conversation on . Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.