Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Looks good for me. |
eirnym approved these changes Jan 14, 2020
| @@ -566,7 +566,7 @@ async def fetchrow(self, query, *args, timeout=None): | |||
| async with self.acquire() as con: | |||
| return await con.fetchrow(query, *args, timeout=timeout) | |||
| def acquire(self, *, timeout=None): | |||
| def acquire(self, *, timeout=None) -> connection.Connection: | |||
There was a problem hiding this comment.
This type hint only covers usual await case:
con = await pool.acquire()But won't work properly for context manager case:
async with pool.acquire() as con:
await con.execute(...)The more correct return type could be something like PoolAcquireContext but we should check if mypy understands it first.
There was a problem hiding this comment.
#577 contains more precise types
It is clear that this is incorrect and should be I'd suggest either changing that in this PR or just closing this and wait until a PR that targets more of these simple methods is created. |
This is superseded by #1209 |
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.