+1 −1
Open

add type for pool.acquire() #521

Changes from all commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e43e597
Update pool.py
TynukuaJan 8, 2020
3028e1b
Merge branch 'master' into -1
TynukuaJan 9, 2020
7d599ae
Merge branch 'master' into -1
TynukuaJan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Failed to load files.
Original file line numberDiff line numberDiff line change
Expand Up@@ -566,7 +566,7 @@ async def fetchrow(self, query, *args, timeout=None):
async with self.acquire() as con:
return await con.fetchrow(query, *args, timeout=timeout)

def acquire(self, *, timeout=None):
def acquire(self, *, timeout=None) -> connection.Connection:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type hint only covers usual await case:

con = await pool.acquire()

But won't work properly for context manager case:

async with pool.acquire() as con:
    await con.execute(...)

The more correct return type could be something like PoolAcquireContext but we should check if mypy understands it first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#577 contains more precise types

"""Acquire a database connection from the pool.

:param float timeout: A timeout for acquiring a Connection.
Expand Down