Open

Addressing #838, STI issues when code is reloaded in development, fix… #1064

Show file tree
Hide file tree
Changes from all commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81536dd
Addressing #838, STI issues when code is reloaded in development, fix…
vanboomNov 10, 2023
11df40b
refactoring index to model map concern into Registry to address #838 …
vanboomNov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Failed to load files.
Original file line numberDiff line numberDiff line change
Expand Up@@ -106,17 +106,15 @@ def __ids_by_type
# @api private
#
def __type_for_hit(hit)
@@__types ||= {}

key = "#{hit[:_index]}::#{hit[:_type]}" if hit[:_type] && hit[:_type] != '_doc'
key = hit[:_index] unless key

@@__types[key] ||= begin
Copy link
Author

@vanboom vanboom Nov 11, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put Benchmark.measure around this code and contrary to my expectations, the original hash method was WAY. We will have to re-think this change, maybe the method of storing the class->index_name mapping can be improved to mitigate #838 with performance.
image

NOTE: my models use a Proc for index_name in a multi-tenant application so we are attempting to use an apartment qualified index name. Seems the Proc based index_name is causing the performance hit.

Registry.all.detect do |model|
(model.index_name == hit[:_index] && __no_type?(hit)) ||
(model.index_name == hit[:_index] && model.document_type == hit[:_type])
end
key = if hit[:_type] && hit[:_type] != '_doc'
"#{hit[:_index]}::#{hit[:_type]}"
else
hit[:_index]
end

# DVB -- #838, refactor the lookup of index name to model into the Registry
Registry.lookup(key, hit[:_type])
end

def __no_type?(hit)
Expand Down