Conversation

olavloite

No description provided.

@olavloiteolavloite added do not mergeIndicates a pull request not ready for merge, due to either quality or timing.api: spannerIssues related to the googleapis/java-spanner API.labels May 6, 2020
@olavloiteolavloite requested a review from skuruppu May 6, 2020 13:36
@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement.label May 6, 2020
@skuruppuskuruppu requested a review from thiagotnunes July 7, 2020 00:31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a first time reviewing, it looks good to me, I think I still lack a bit of understanding on how all the pieces come together.

@@ -352,6 +356,21 @@ public void writeDateNull() {
assertThat(row.isNull(0)).isTrue();
}

@Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olavloite thanks for adding the integration tests. But I do have one small request. Would you be able to move it to a separate PR?

The reason being that we will merge this PR in before support for the feature is available in prod, which unfortunately mean that the tests will fail at that point.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NP, I'll move them to a separate PR.

@olavloiteolavloite changed the base branch from java-code-regen to master July 15, 2020 07:36
@skuruppuskuruppu removed the do not mergeIndicates a pull request not ready for merge, due to either quality or timing.label Jul 15, 2020
@skuruppuskuruppu merged commit b38a91d into googleapis:master Jul 15, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 16, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.59.0](https://www..com/googleapis/java-spanner/compare/v1.58.0...v1.59.0) (2020-07-16)


### Features

* add support for NUMERIC data type ([#193](https://www..com/googleapis/java-spanner/issues/193)) ([b38a91d](https://www..com/googleapis/java-spanner/commit/b38a91d8daac264b9dea327d6b31430d9599bd78))
* spanner NUMERIC type ([#349](https://www..com/googleapis/java-spanner/issues/349)) ([78c3192](https://www..com/googleapis/java-spanner/commit/78c3192266c474fc43277a8bf3f15caa968a0100))


### Bug Fixes

* check if emulator is running if env var is set ([#340](https://www..com/googleapis/java-spanner/issues/340)) ([597f501](https://www..com/googleapis/java-spanner/commit/597f501803e6d58717a6e3770e6fd3f34454e9a5))
* fix potential unnecessary transaction retry ([#337](https://www..com/googleapis/java-spanner/issues/337)) ([1a4f4fd](https://www..com/googleapis/java-spanner/commit/1a4f4fd675a1580c87ad1d53c650a20bd2ff4811)), closes [#327](https://www..com/googleapis/java-spanner/issues/327)
* respect PDML timeout when using  RPC ([#338](https://www..com/googleapis/java-spanner/issues/338)) ([d67f108](https://www..com/googleapis/java-spanner/commit/d67f108e86925c1296e695db8e78fa82e11fa4fa))
* runs sample tests in java 8 and java 11 ([#345](https://www..com/googleapis/java-spanner/issues/345)) ([b547e31](https://www..com/googleapis/java-spanner/commit/b547e31d095be3cf1646e0e9c07bfc467ecc3c22))
* set gRPC keep-alive to 120 seconds ([#339](https://www..com/googleapis/java-spanner/issues/339)) ([26be103](https://www..com/googleapis/java-spanner/commit/26be103da1117c4940550fad1672c66e6edfbdb3))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.3 ([#334](https://www..com/googleapis/java-spanner/issues/334)) ([45acd89](https://www..com/googleapis/java-spanner/commit/45acd8960c961d48e91a7b1546efa64d9e9ae576))
* update shared config to 0.9.2 ([#328](https://www..com/googleapis/java-spanner/issues/328)) ([75df62c](https://www..com/googleapis/java-spanner/commit/75df62c0176137fda1d0a9076b83be06f11228ce))
---


This PR was generated with [Release Please](https://.com/googleapis/release-please).
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on . Already have an account? Sign in to comment
api: spannerIssues related to the googleapis/java-spanner API.cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.