Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
thiagotnunes approved these changes Jul 7, 2020
...loud-spanner/src/test/java/com/google/cloud/spanner/connection/RandomResultSetGenerator.java Outdated Show resolved Hide resolved
Uh oh!
There was an error while loading. Please reload this page.
| @@ -352,6 +356,21 @@ public void writeDateNull() { | |||
| assertThat(row.isNull(0)).isTrue(); | |||
| } | |||
| @Test | |||
There was a problem hiding this comment.
@olavloite thanks for adding the integration tests. But I do have one small request. Would you be able to move it to a separate PR?
The reason being that we will merge this PR in before support for the feature is available in prod, which unfortunately mean that the tests will fail at that point.
There was a problem hiding this comment.
NP, I'll move them to a separate PR.
skuruppu approved these changes Jul 14, 2020
skuruppu approved these changes Jul 15, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 16, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.59.0](https://www..com/googleapis/java-spanner/compare/v1.58.0...v1.59.0) (2020-07-16) ### Features * add support for NUMERIC data type ([#193](https://www..com/googleapis/java-spanner/issues/193)) ([b38a91d](https://www..com/googleapis/java-spanner/commit/b38a91d8daac264b9dea327d6b31430d9599bd78)) * spanner NUMERIC type ([#349](https://www..com/googleapis/java-spanner/issues/349)) ([78c3192](https://www..com/googleapis/java-spanner/commit/78c3192266c474fc43277a8bf3f15caa968a0100)) ### Bug Fixes * check if emulator is running if env var is set ([#340](https://www..com/googleapis/java-spanner/issues/340)) ([597f501](https://www..com/googleapis/java-spanner/commit/597f501803e6d58717a6e3770e6fd3f34454e9a5)) * fix potential unnecessary transaction retry ([#337](https://www..com/googleapis/java-spanner/issues/337)) ([1a4f4fd](https://www..com/googleapis/java-spanner/commit/1a4f4fd675a1580c87ad1d53c650a20bd2ff4811)), closes [#327](https://www..com/googleapis/java-spanner/issues/327) * respect PDML timeout when using RPC ([#338](https://www..com/googleapis/java-spanner/issues/338)) ([d67f108](https://www..com/googleapis/java-spanner/commit/d67f108e86925c1296e695db8e78fa82e11fa4fa)) * runs sample tests in java 8 and java 11 ([#345](https://www..com/googleapis/java-spanner/issues/345)) ([b547e31](https://www..com/googleapis/java-spanner/commit/b547e31d095be3cf1646e0e9c07bfc467ecc3c22)) * set gRPC keep-alive to 120 seconds ([#339](https://www..com/googleapis/java-spanner/issues/339)) ([26be103](https://www..com/googleapis/java-spanner/commit/26be103da1117c4940550fad1672c66e6edfbdb3)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.3 ([#334](https://www..com/googleapis/java-spanner/issues/334)) ([45acd89](https://www..com/googleapis/java-spanner/commit/45acd8960c961d48e91a7b1546efa64d9e9ae576)) * update shared config to 0.9.2 ([#328](https://www..com/googleapis/java-spanner/issues/328)) ([75df62c](https://www..com/googleapis/java-spanner/commit/75df62c0176137fda1d0a9076b83be06f11228ce)) --- This PR was generated with [Release Please](https://.com/googleapis/release-please).
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on . Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.