Conversation

olavloite

The gRPC keep-alive was set to 120,000 seconds instead of 120 seconds.

@olavloiteolavloite requested a review from skuruppu July 10, 2020 16:47
@olavloiteolavloite added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Jul 10, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry I didn't notice this earlier.

@skuruppuskuruppu added cla: yesThis human has signed the Contributor License Agreement.and removed cla: yesThis human has signed the Contributor License Agreement.labels Jul 14, 2020
@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement.label Jul 14, 2020
@skuruppuskuruppu merged commit 26be103 into master Jul 14, 2020
@skuruppuskuruppu deleted the keep-alive branch July 14, 2020 03:05
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 16, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.59.0](https://www..com/googleapis/java-spanner/compare/v1.58.0...v1.59.0) (2020-07-16)


### Features

* add support for NUMERIC data type ([#193](https://www..com/googleapis/java-spanner/issues/193)) ([b38a91d](https://www..com/googleapis/java-spanner/commit/b38a91d8daac264b9dea327d6b31430d9599bd78))
* spanner NUMERIC type ([#349](https://www..com/googleapis/java-spanner/issues/349)) ([78c3192](https://www..com/googleapis/java-spanner/commit/78c3192266c474fc43277a8bf3f15caa968a0100))


### Bug Fixes

* check if emulator is running if env var is set ([#340](https://www..com/googleapis/java-spanner/issues/340)) ([597f501](https://www..com/googleapis/java-spanner/commit/597f501803e6d58717a6e3770e6fd3f34454e9a5))
* fix potential unnecessary transaction retry ([#337](https://www..com/googleapis/java-spanner/issues/337)) ([1a4f4fd](https://www..com/googleapis/java-spanner/commit/1a4f4fd675a1580c87ad1d53c650a20bd2ff4811)), closes [#327](https://www..com/googleapis/java-spanner/issues/327)
* respect PDML timeout when using  RPC ([#338](https://www..com/googleapis/java-spanner/issues/338)) ([d67f108](https://www..com/googleapis/java-spanner/commit/d67f108e86925c1296e695db8e78fa82e11fa4fa))
* runs sample tests in java 8 and java 11 ([#345](https://www..com/googleapis/java-spanner/issues/345)) ([b547e31](https://www..com/googleapis/java-spanner/commit/b547e31d095be3cf1646e0e9c07bfc467ecc3c22))
* set gRPC keep-alive to 120 seconds ([#339](https://www..com/googleapis/java-spanner/issues/339)) ([26be103](https://www..com/googleapis/java-spanner/commit/26be103da1117c4940550fad1672c66e6edfbdb3))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.3 ([#334](https://www..com/googleapis/java-spanner/issues/334)) ([45acd89](https://www..com/googleapis/java-spanner/commit/45acd8960c961d48e91a7b1546efa64d9e9ae576))
* update shared config to 0.9.2 ([#328](https://www..com/googleapis/java-spanner/issues/328)) ([75df62c](https://www..com/googleapis/java-spanner/commit/75df62c0176137fda1d0a9076b83be06f11228ce))
---


This PR was generated with [Release Please](https://.com/googleapis/release-please).
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genmgr will
update the corresponding CL at gocloud to depend on the newer version of
go-genproto, and assign reviewers. Whilst this or any regen PR is open in
go-genproto, gapicgen will not create any more regeneration PRs or CLs. If all
regen PRs are closed, gapicgen will create a new set of regeneration PRs and
CLs once per night.

If you have been assigned to review this CL, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
  genmgr to assign reviewers to the gocloud CL.

Corresponding gocloud CL: https://code-review.googlesource.com/c/gocloud/+/54275
Sign up for free to join this conversation on . Already have an account? Sign in to comment
cla: yesThis human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.