Conversation

dizcology

DO NOT MERGE until sample tests passing.

vinnysenthil and others added 5 commits November 2, 2020 11:15
@vinnysenthil @release-please @busunkim96
feat: Migrate sample and sample tests - Batch 1 of 5 (#11)
c37c8ef
* chore: release 0.2.0

* Init samples and sample tests - Batch 1

* Add pytest to nox requirements

* Add dependency on library itself for testing

* Address reviewer comments - 1 of 5

* Add sample test resources

* Revert Changelog to 

* Revert Changelog to  (part 2)

* Update tabular + GAPIC namespace (B1/5)

* Update tabular + GAPIC namespace (B1/5) (part 2)

* Sync to private repo (1/5)

* Address requested changes

* Add / assertions, timeout as a sample param

* Sync with private (1/5) and address comments

* Add / assert to cancel_training_pipeline_test

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply..com>
Co-authored-by: Bu Sun Kim <[email protected]>
@vinnysenthil @release-please
@busunkim96 @aribray
feat: Migrate sample and sample tests - Batch 2 of 5 (#12)
e1c3e50
* chore: release 0.2.0

* Init samples and sample tests - Batch 2

* Address reviewer comments - 2 of 5

* Drop CHANGELOG

* Revert Changelog to 

* Update tabular + GAPIC namespace (B2/5)

* Update tabular + GAPIC namespace (B2/5) (part 2)

* Sync with private repo (2/5) and address comments

* Add more assertions, fix tests

* rename test files

* addd link to node hours pricing

* add init.py, fix path to import

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply..com>
Co-authored-by: Bu Sun Kim <[email protected]>
Co-authored-by: Ariana Bray <[email protected]>
@vinnysenthil @release-please
@busunkim96 @aribray
feat: Migrate sample and sample tests - Batch 3 of 5 (#13)
efc405f
* chore: release 0.2.0

* Init samples and sample tests - Batch 3

* chore: release 0.2.0

* Address reviewer comments - 3 of 5

* Add two extra samples + tests

* Revert Changelog to 

* Update tabular + GAPIC namespace (B3/5)

* Sync with private repo (3/5)

* Add UUID to export_model sample test

* remove unused variables

* add no-arg wrapper function to initialize user inputs

* pass environment variables for fixed resources

* refactor print statement

* add no-arg wrapper function to initialize user inputs

* add no-arg wrapper functions to all samples

* add no-arg wrapper function

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply..com>
Co-authored-by: Bu Sun Kim <[email protected]>
Co-authored-by: Ariana Bray <[email protected]>
@vinnysenthil @release-please
@busunkim96 @aribray
feat: Migrate sample and sample tests - Batch 4 of 5 (#14)
e1e3d19
* chore: release 0.2.0

* Init samples and sample tests - Batch 4

* Address reviewer comments - 4 of 5

* Revert Changelog to 

* Update tabular + GAPIC namespace (B4/5)

* Sync with private repo (4/5)

* wrapped line

* add explanation to test

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply..com>
Co-authored-by: Bu Sun Kim <[email protected]>
Co-authored-by: Ariana Bray <[email protected]>
@vinnysenthil @release-please
@busunkim96 @aribray
feat: Migrate sample and sample tests - Batch 5 of 5 (#15)
b982be3
* chore: release 0.2.0

* Init samples and sample tests - Batch 5

* Address reviewer comments - 5 of 5

* Revert Changelog to 

* Update tabular + GAPIC namespace (B5/5)

* Sync with private repo (5/5)

* Update samples/list_model_evaluation_slices_sample.py

Co-authored-by: Bu Sun Kim <[email protected]>

* format PredictRequest

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply..com>
Co-authored-by: Bu Sun Kim <[email protected]>
Co-authored-by: aribray <[email protected]>
Co-authored-by: Ariana Bray <[email protected]>
@dizcologydizcology added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing.label Nov 12, 2020
@dizcologydizcology requested review from a team as code owners November 12, 2020 17:56
@google-clagoogle-cla bot added the cla: yesThis human has signed the Contributor License Agreement.label Nov 12, 2020
@dizcologydizcology removed the request for review from kurtisvg November 12, 2020 17:56
@snippet-bot

Here is the summary of changes.

You added 74 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label.

@dizcologydizcology changed the title Samples feat: add samples Nov 12, 2020
@google-cla

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-clagoogle-cla bot added cla: noThis human has *not* signed the Contributor License Agreement.and removed cla: yesThis human has signed the Contributor License Agreement.labels Nov 13, 2020
@dizcology

@googlebot I consent.

@google-cla

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@vinnysenthil

@googlebot I consent.

@google-clagoogle-cla bot added cla: yesThis human has signed the Contributor License Agreement.and removed cla: noThis human has *not* signed the Contributor License Agreement.labels Nov 13, 2020
busunkim96
busunkim96 approved these changes Nov 13, 2020
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping per discussion over email on how sample reviewer comments will be addressed.

@vinnysenthilvinnysenthil added cla: noThis human has *not* signed the Contributor License Agreement.and removed do not mergeIndicates a pull request not ready for merge, due to either quality or timing.cla: no cla: noThis human has *not* signed the Contributor License Agreement.labels Nov 13, 2020
@dizcologydizcology added the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Nov 13, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-runAdd this label to force Kokoro to re-run the tests.label Nov 13, 2020
@dizcologydizcology merged commit 53cc5f5 into master Nov 13, 2020
@vinnysenthilvinnysenthil deleted the sample-final-stage branch December 3, 2021 08:41
@Ark-kun
# The AI Platform services require regional API endpoints.
client_options = {"api_endpoint": api_endpoint}

Are regional API endpoints still required?

Sign up for free to join this conversation on . Already have an account? Sign in to comment

@busunkim96 busunkim96 busunkim96 approved these changes

@vinnysenthil vinnysenthil vinnysenthil approved these changes

No one assigned
cla: yesThis human has signed the Contributor License Agreement.
None yet
No milestone

Successfully merging this pull request may close these issues.