Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolved a minor bug where Slice was returning an newline when an empty string slice was passed into it.
The expected behaviour:
The Actual Behaviour:
Use Case for PR
This MR will add logic that will tell Slice to check the length of the incoming string slice (
len([]string{ ... })
) and if it's less than or equal to 0, or if it's empty, it should tell Slice to return a pipe containing an empty string rather than a"\n"
Slice is used often in the script codebase particularly in
ListFiles()
where the bug was first discovered. This implementation should resolve it.