Open

#110 - Fix Slice bug producing a \n when provided with an empty slice #115

Changes from 1 commit
Show all changes
12 commits
Select commit Hold shift + click to select a range
04c4e92
Added if statement that returns no new line if there an empty splice
hsheikhali1May 3, 2022
12bf171
add todo nnote
hsheikhali1May 3, 2022
21d3ec1
added passing test
hsheikhali1PMay 10, 2022
308cdc6
removed commented out string
hsheikhali1PMay 10, 2022
195bc2f
removed tests for list files and moved them
hsheikhali1May 10, 2022
7c6bf02
removed todo
hsheikhali1May 10, 2022
ea4b50d
updated test to include an empty list
hsheikhali1May 11, 2022
99fc5ae
removed log package ...
hsheikhali1May 14, 2022
32cfe70
Merge remote-tracking branch 'origin' into hsheikhali/fix-slice-bug
hsheikhali1PAug 26, 2022
1786a6d
added suggestions
hsheikhali1PAug 26, 2022
b3566e4
fixing commit history
hsheikhali1Aug 26, 2022
f6676bd
fixing commit history
hsheikhali1Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Failed to load files.
PrevPrevious commit
Next Next commit
updated test to include an empty list
  • Loading branch information
@hsheikhali1
hsheikhali1 committedMay 11, 2022
commit ea4b50d6a361e8397b65de8f6fcdaff7e6591c46
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@ import (
"errors"
"fmt"
"io"
"log"
"os"
"os/exec"
"path/filepath"
Expand DownExpand Up@@ -1124,7 +1125,7 @@ func TestSliceProducesNoElementsWhenProvidedWithAnEmptyList(t *testing.T) {
t.Parallel()

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but it's house style with this project to use no blank lines within functions. To my mind, they just make the function longer without providing any benefit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a thing I have built into muscle memory from my typescript work.. I noticed some Go devs prefer not to have a bunch of blank lines

want := ""
got, err := script.ListFiles("../example").String()
got, err := script.Slice([]string{}).String()

if err != nil {
t.Fatal(err)
Expand Down