Open

#110 - Fix Slice bug producing a \n when provided with an empty slice #115

Changes from 1 commit
Show all changes
12 commits
Select commit Hold shift + click to select a range
04c4e92
Added if statement that returns no new line if there an empty splice
hsheikhali1May 3, 2022
12bf171
add todo nnote
hsheikhali1May 3, 2022
21d3ec1
added passing test
hsheikhali1PMay 10, 2022
308cdc6
removed commented out string
hsheikhali1PMay 10, 2022
195bc2f
removed tests for list files and moved them
hsheikhali1May 10, 2022
7c6bf02
removed todo
hsheikhali1May 10, 2022
ea4b50d
updated test to include an empty list
hsheikhali1May 11, 2022
99fc5ae
removed log package ...
hsheikhali1May 14, 2022
32cfe70
Merge remote-tracking branch 'origin' into hsheikhali/fix-slice-bug
hsheikhali1PAug 26, 2022
1786a6d
added suggestions
hsheikhali1PAug 26, 2022
b3566e4
fixing commit history
hsheikhali1Aug 26, 2022
f6676bd
fixing commit history
hsheikhali1Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Failed to load files.
PrevPrevious commit
fixing commit history
  • Loading branch information
@hsheikhali1
hsheikhali1 committedAug 26, 2022
commit f6676bdff16b872fb6a926f8f44c6b14bd5b9ac4
Original file line numberDiff line numberDiff line change
Expand Up@@ -1128,7 +1128,7 @@ func TestSliceProducesElementsOfSpecifiedSliceOnePerLine(t *testing.T) {

func TestSliceGivenEmptySliceProducesEmptyPipe(t *testing.T) {
t.Parallel()
want := "\n"
want := ""
got, err := script.Slice([]string{}).String()
if err != nil {
t.Fatal(err)
Expand Down